<p></p>
<p><b>@nenad-vujicic</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4904#discussion_r1712006776">app/assets/javascripts/index/directions.js</a>:</p>
<pre style='color:#555'>>      });
 
-    endpoint.setValue = function (value, latlng) {
+    endpoint.setValue = function (value, force_reverse_geocoding, latlng, fitMap) {
</pre>
<blockquote>
<p dir="auto">Why would a single endpoint control fitting?</p>
</blockquote>
<p dir="auto">Because the route can change on single endpoint update, so, it can go out of viewing area and we need to fit bounds.</p>
<blockquote>
<p dir="auto">Then below you have:</p>
<pre class="notranslate"><code class="notranslate">endpoints[0].setValue(params.from || "", !ll_from_search_form, from, false);
endpoints[1].setValue(params.to || "", !ll_from_search_form, to, true);
</code></pre>
<p dir="auto">And not it's not clear why the first endpoint gets <code class="notranslate">fitMap = false</code> but the second one gets <code class="notranslate">fitMap = true</code>.</p>
</blockquote>
<p dir="auto">Because in some situations there is a flickering if we are doing fitting both times.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4904#discussion_r1712006776">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNSYXLWU7SCAH6CPZDZQUG3NAVCNFSM6AAAAABJN5ACBGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMZQHA3TAMJWHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLK7PBXLPMUNX5JUFKTZQUG3NA5CNFSM6AAAAABJN5ACBGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUE7BQJQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4904/review/2230870168</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4904#discussion_r1712006776",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4904#discussion_r1712006776",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>