<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5069#discussion_r1716175524">app/helpers/user_blocks_helper.rb</a>:</p>
<pre style='color:#555'>> @@ -20,7 +20,7 @@ def block_status(block)
       # the max of the last update time or the ends_at time is when this block finished
       # either because the user viewed the block (updated_at) or it expired or was
       # revoked (ends_at)
-      last_time = [block.ends_at, block.updated_at].max
+      last_time = block.deactivates_at || [block.ends_at, block.updated_at].max
</pre>
<p dir="auto">Yes, this is until backfilling is done. After that the logic will be simpler everywhere. <code class="notranslate">last_time</code> is just <code class="notranslate">block.deactivates_at</code>, <code class="notranslate">block.active?</code> is comparing the current time with <code class="notranslate">block.deactivates_at</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5069#discussion_r1716175524">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNL4WEDHMPJECKTA4LZRKVSJAVCNFSM6AAAAABMOBVSWOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMZWHE2DOMZQHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLM2Y23PQTF2YPT6SO3ZRKVSJA5CNFSM6AAAAABMOBVSWOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUFKUNWY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5069/review/2236947308</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5069#discussion_r1716175524",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5069#discussion_r1716175524",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>