<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4985#discussion_r1718398441">app/helpers/application_helper.rb</a>:</p>
<pre style='color:#555'>> +
+ # Log invalid sites
+ invalid_sites.each do |invalid_site|
+ Rails.logger.error("Invalid site or icon not configured: #{invalid_site}")
+ end
+
+ tag.div(
+ :class => "social-share-button d-flex gap-1 align-items-end flex-wrap"
+ ) do
+ valid_sites.map do |site|
+ link_to SocialShareButtonHelper.generate_share_url(site, opts), {
+ :rel => ["nofollow", opts[:rel]].compact,
+ :class => "ssb-icon",
+ :title => "Share on #{site.capitalize}"
+ } do
+ image_tag(SocialShareButtonHelper.icon_path(site), :alt => site.capitalize, :size => 28)
</pre>
<p dir="auto"><code class="notranslate">:alt => site.capitalize</code>: "email" is not a proper site name, you'll have to translate it instead of just capitalizing.</p>
<p dir="auto">You'll have something like:<br>
<a href="https://github.com/openstreetmap/openstreetmap-website/blob/1b288d40c7fff3d3be8d82d4e96c9008778f4dba/config/locales/en.yml#L2597-L2614">https://github.com/openstreetmap/openstreetmap-website/blob/1b288d40c7fff3d3be8d82d4e96c9008778f4dba/config/locales/en.yml#L2597-L2614</a></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4985#pullrequestreview-2240383961">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLI3F4OJI7ASZ4EGMEDZRSTQFAVCNFSM6AAAAABK2RPBLKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENBQGM4DGOJWGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNBECUWG6CIUZSHTQLZRSTQFA5CNFSM6AAAAABK2RPBLKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUFRGF5S.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4985/review/2240383961</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4985#pullrequestreview-2240383961",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4985#pullrequestreview-2240383961",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>