<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4985#discussion_r1718450684">lib/social_share_button_helper.rb</a>:</p>
<pre style='color:#555'>> +    [valid_sites, invalid_sites]
+  end
+
+  def self.icon_path(site)
+    SOCIAL_SHARE_CONFIG[site.to_sym] || ""
+  end
+
+  def self.valid_site?(site)
+    SOCIAL_SHARE_CONFIG.key?(site.to_sym)
+  end
+
+  def self.generate_share_url(site, params)
+    site = site.to_sym
+    case site
+    when :email
+      "mailto:?subject=#{URI.encode_www_form_component(params[:title])}&body=#{URI.encode_www_form_component(params[:url])}"
</pre>
<p dir="auto"><code class="notranslate">URI.encode_www_form_component</code> is a bit different from javascript's <code class="notranslate">encodeURIComponent</code>. It encodes spaces as <code class="notranslate">+</code>. But <a href="https://datatracker.ietf.org/doc/html/rfc6068#section-5" rel="nofollow">mailto rfc</a> says spaces should be encoded as <code class="notranslate">%20</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4985#pullrequestreview-2240467666">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOXTBXORHVFELDOCF3ZRSYSHAVCNFSM6AAAAABK2RPBLKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENBQGQ3DONRWGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLCUORWINYPY727Q63ZRSYSHA5CNFSM6AAAAABK2RPBLKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUFRLJNE.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4985/review/2240467666</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4985#pullrequestreview-2240467666",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4985#pullrequestreview-2240467666",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>