<p></p>
<p><b>@nertc</b> requested changes on this pull request.</p>

<p dir="auto">The change is functional, only the needed parts are rendered, and pagination works properly with history advancing and optimizations. After these two lines will be corrected, I think, this PR will be ready for merging.</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4646#discussion_r1722813610">app/views/diary_comments/_page.html.erb</a>:</p>
<pre style='color:#555'>> +    <tr>
+      <td width="25%" class="<%= "text-body-secondary" unless comment.visible? %>"><%= link_to comment.diary_entry.title, diary_entry_path(comment.diary_entry.user, comment.diary_entry) %></td>
+      <td width="25%" class="<%= "text-body-secondary" unless comment.visible? %>">
+        <%= friendly_date_ago(comment.created_at) %>
+      </td>
+      <td width="50%" class="richtext text-break<%= " text-body-secondary" unless comment.visible? %>"><%= comment.body.to_html %></td>
+    </tr>
+    <% end -%>
+  </table>
+
+  <%= render "shared/pagination",
+             :newer_key => "diary_comments.page.newer_comments",
+             :older_key => "diary_comments.page.older_comments",
+             :newer_id => @newer_comments_id,
+             :older_id => @older_comments_id %>
+</frame>
</pre>
<p dir="auto"><code class="notranslate">turbo-frame</code> tag was opened, but <code class="notranslate">frame</code> tag was closed. Instead of <code class="notranslate"></frame></code> should be <code class="notranslate"></turbo-frame></code></p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4646#discussion_r1722815195">app/views/traces/_page.html.erb</a>:</p>
<pre style='color:#555'>> +             :older_key => "traces.page.older",
+             :newer_id => @newer_traces_id,
+             :older_id => @older_traces_id %>
+
+  <table id="trace_list" class="table table-borderless table-striped">
+    <tbody>
+      <%= render @traces %>
+    </tbody>
+  </table>
+
+  <%= render "shared/pagination",
+             :newer_key => "traces.page.newer",
+             :older_key => "traces.page.older",
+             :newer_id => @newer_traces_id,
+             :older_id => @older_traces_id %>
+</turbo-frame id="pagination">
</pre>
<p dir="auto">Closing tag doesn't need <code class="notranslate">id</code>. Instead of <code class="notranslate"></turbo-frame id="pagination"></code> should be <code class="notranslate"></turbo-frame></code></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4646#pullrequestreview-2247165755">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMGD6YEI6YG3F7DTPTZSLWIRAVCNFSM6AAAAABFV2CCZGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENBXGE3DKNZVGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNA2NVU5OZ5UCF6I2LZSLWIRA5CNFSM6AAAAABFV2CCZGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUF6EDTW.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4646/review/2247165755</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4646#pullrequestreview-2247165755",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4646#pullrequestreview-2247165755",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>