<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<p dir="auto">Why exactly do we want to stop other moderators editing unless they also revoke?</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5104#discussion_r1725472357">app/abilities/ability.rb</a>:</p>
<pre style='color:#555'>> @@ -60,7 +60,10 @@ def initialize(user)
           can [:index, :show, :resolve, :ignore, :reopen], Issue
           can :create, IssueComment
           can [:new, :create, :edit, :update, :destroy], Redaction
-          can [:new, :edit, :create, :update, :revoke, :revoke_all], UserBlock
+          can [:new, :create, :revoke, :revoke_all], UserBlock
+          can :update, UserBlock, :creator => user
+          can :update, UserBlock, :revoker => user
+          can :update, UserBlock, :active? => true
</pre>
<p dir="auto">Does this act as an AND or an OR of the conditions? Because neither seems right? Surely we want active AND (creator OR revoker) as the test?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5104#pullrequestreview-2251492848">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIBPZCJZSFTPAROLODZSTGTZAVCNFSM6AAAAABM4JIKO6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENJRGQ4TEOBUHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIIT3VWGNMVSAXVMG3ZSTGTZA5CNFSM6AAAAABM4JIKO6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUGGMG7A.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5104/review/2251492848</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5104#pullrequestreview-2251492848",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5104#pullrequestreview-2251492848",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>