<p></p>
<p><b>@gravitystorm</b> commented on this pull request.</p>
<p dir="auto">I'm at a bit of a loss how to approach this review, since the diff is huge (1700+ additions).</p>
<p dir="auto">So we could do this in two ways - I can go through the details (e.g. <code class="notranslate"><label></code> should only be used for forms, it shouldn't have custom CSS, the <code class="notranslate"><h1></code> in communities#index uses lego translations etc) or we can tackle the big picture (e.g. renaming the existing Communities model/controller, whether we want Yet Another OSM Thing Called Communities, etc).</p>
<p dir="auto">What would be more helpful? Or should I just send you a stream of feedback as I go?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3717#pullrequestreview-2251493595">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNLBJMME3TDUVFHZDLZSTF5LAVCNFSM6AAAAAAQUYXU56VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENJRGQ4TGNJZGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNSNS375GFZIMUQPBTZSTF5LA5CNFSM6AAAAAAQUYXU56WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUGGMINW.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3717/review/2251493595</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3717#pullrequestreview-2251493595",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3717#pullrequestreview-2251493595",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>