<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5107#discussion_r1727726132">test/system/dashboard_test.rb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,27 @@
+require "application_system_test_case"
+
+class DashboardSystemTest < ApplicationSystemTestCase
</pre>
<p dir="auto">I wonder if we're doing something wrong with our system test naming... Other non-model tests like controller tests always put controller in the name and can be consistent between class and file names.</p>
<p dir="auto">I can't say I like having odd cases where they don't align, and there isn't even a clash here, but I guess there is precedent.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5107#discussion_r1727726132">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLO75F4NEDTSNR5GME3ZSY6EJAVCNFSM6AAAAABM6KSNHKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENJVGUZDEOJRGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOPPKJTIC57T4HUCTDZSY6EJA5CNFSM6AAAAABM6KSNHKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUGOCGF6.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5107/review/2255522911</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5107#discussion_r1727726132",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5107#discussion_r1727726132",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>