<p dir="auto">Something had to break after <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2223589340" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4646" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4646/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4646">#4646</a>.</p>
<p dir="auto">Turbo handles all links inside its frames unless told not to. If any link leads to a page that has some javascript running on load, it's going to be broken. The most common javascript in our case is rich rext controls code. If you go to a diaries page and click "comment", turbo takes you to a diary entry page with broken richtext javascript.</p>
<p dir="auto">I did here the same as in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2174336382" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4565" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4565/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4565">#4565</a>: set <code class="notranslate">data-turbo="false"</code> on the entire frame and set it to true just on previous/next page links.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5111'>https://github.com/openstreetmap/openstreetmap-website/pull/5111</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5111/commits/52324cba89a3f4d211535119a20f967593813c09" class="commit-link">52324cb</a>  Disable turbo on all links inside pagination frames except older/newer</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5111/files">6 files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5111/files#diff-2479587a3b432070e3d95d96bf5b0a7f5f88896d62f0092d4f0346485ee29244">app/views/diary_comments/_page.html.erb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5111/files#diff-2fb9f160e757fc434d16f8e8cd9aa573eedd02f6d356408963e10bca184dd1a2">app/views/diary_entries/_page.html.erb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5111/files#diff-2a43f1a5b4e2bda5df6ec18928f70304b3e1e3bcb084c26cc00d3ed34dab9062">app/views/shared/_pagination.html.erb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5111/files#diff-8e0d2926ac2ebfe8582d2769b69be92e0cf99539bf9e1dc1ff39d0741debf667">app/views/traces/_page.html.erb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5111/files#diff-c168d2324bc74e9bd639f796e23def66db563d9457b7d4a2c05b109552804a4c">app/views/user_blocks/_blocks.html.erb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5111/files#diff-8a713fbc67e1fc4b373fee264bd91767b9fd2f7574304e022566864afebbf430">app/views/users/_page.html.erb</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5111.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5111.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5111.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5111.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5111">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPEV5JPFB6QUC3VFGDZS4Q33AVCNFSM6AAAAABNABURFCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ4DGMBQGMYDCMA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNSSHMYGMEATMW66ADZS4Q33A5CNFSM6AAAAABNABURFCWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHJH746QI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5111</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5111",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5111",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>