<p dir="auto">Followup to <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2190983587" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4587" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4587/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4587">#4587</a></p>
<p dir="auto">We usually create nested controllers with the main controller as the module, and the nested controller as the specialization, e.g. Users::DeletionsController or Traces::IconsController.</p>
<p dir="auto">This then leaves the topic of whether the feed resource is plural, and whether we are then showing a singular feed or showing a list (index) of objects.</p>
<p dir="auto">The routes are carefully named so that we have <code class="notranslate">changesets_comments_feed_path</code> (the comments feed for all changesets) vs <code class="notranslate">changeset_comment_feed_path(changeset)</code> (the comments for a singular changeset).</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5126'>https://github.com/openstreetmap/openstreetmap-website/pull/5126</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5126/commits/10a4c5cf6e1165a9db6e9b87d0fa19d7f97b51bf" class="commit-link">10a4c5c</a>  Rename Feeds::ChangesetCommentsController to ChangesetComments::FeedsController</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5126/files">10 files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5126/files#diff-debf59904131dc89a88ab44cbb1d6deaaa5a7d70c0507f674080df62f7c8e41f">app/abilities/ability.rb</a>
    (2)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5126/files#diff-639d5c1d01849e957559a462cfdbef957f17048596460c6106a5a62e3743c142">app/controllers/changeset_comments/feeds_controller.rb</a>
    (8)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5126/files#diff-5ad45b0d34e6704ee66683e654fc56e95996dcfc82f24016d7a60dc74b6c8ae2">app/views/changeset_comments/feeds/_comment.html.erb</a>
    (0)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5126/files#diff-dc36b5dc19de2946c22ba426f2754aa96fb126beb615a20d25baaa67cec2d393">app/views/changeset_comments/feeds/_comment.rss.builder</a>
    (0)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5126/files#diff-c2460f5c5185bb55b016f6f50fd7b360600820b10384ffc8f0e8d3980cacf0f2">app/views/changeset_comments/feeds/show.rss.builder</a>
    (0)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5126/files#diff-0a3cc792e4d6ef0fa0213eeff1f27e3f9411cf97a4953799f2b88bfcbbf35ccc">app/views/changeset_comments/feeds/timeout.atom.builder</a>
    (0)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5126/files#diff-3c9b9d14d39d6a13d8e5368f6cf5e713e0091c7978a2140fc4bbe36767e9e53f">app/views/changeset_comments/feeds/timeout.html.erb</a>
    (0)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5126/files#diff-44438ce218f5287c58d0017f965d888715635d94280669896f75841fbd7b4cd7">config/locales/en.yml</a>
    (24)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5126/files#diff-959bc9abc46a55332bb64d5155a79323afa75a50ec1a2137ddd22d926f62c6c5">config/routes.rb</a>
    (10)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5126/files#diff-7da307b49309a98fb76c4d1a0c385f7e524579f58f06de523c17c5ae37aab7f0">test/controllers/changeset_comments/feeds_controller_test.rb</a>
    (18)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5126.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5126.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5126.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5126.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5126">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIJTLV7EINRHDTJHYLZTYD7LAVCNFSM6AAAAABNIY3Z3OVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ4TENRWGY2TGMQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLK7N2BD6MIQ6Z2AJWTZTYD7LA5CNFSM6AAAAABNIY3Z3OWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHJJEYSUQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5126</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5126",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5126",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>