<p></p>
<p dir="auto">I've spent some time considering your point about whether we are <code class="notranslate">:show</code>ing a feed, or <code class="notranslate">:index</code>ing a list of changeset comments. In doing so, I've realised that I think the module naming in this PR might be the wrong way round, i.e. <code class="notranslate">Feeds::ChangesetCommentsController</code> vs <code class="notranslate">ChangesetComments::FeedsController</code>.</p>
<p dir="auto">But with everything related to <code class="notranslate">routes.rb</code>, the only way I can be sure is by messing around and seeing what happens, and now I have an alternative approach ready that I prefer, but I'm not sure what you will think of it.</p>
<p dir="auto">So what I'm going to do is merge this PR, so that it unblocks your work, and then make my own followup PR for you to review.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4587#issuecomment-2315905389">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMLD647SD6WOHK4QPTZTYCLTAVCNFSM6AAAAABE2UEXAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJVHEYDKMZYHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLI3YGJVNJSK4DPXMDZTYCLTA5CNFSM6AAAAABE2UEXAWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUKBHUW2.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4587/c2315905389</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4587#issuecomment-2315905389",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4587#issuecomment-2315905389",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>