<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5141#discussion_r1741126081">test/controllers/api/changeset_comments_controller_test.rb</a>:</p>
<pre style='color:#555'>> # abilities take into account terms agreement too.
- def test_api_write_and_terms_agreed_via_basic_auth
+ def test_api_write_and_terms_agreed_via_oauth
</pre>
<p dir="auto">Do we need this test? What's the difference between it and the previous <code class="notranslate">_via_token</code> test? Only token scopes?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5141#pullrequestreview-2275984077">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLFSWVIT2FVU2ZXR7DZUSJCZAVCNFSM6AAAAABNO4QQA2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENZVHE4DIMBXG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOIOYDW2PGPNPB5O4DZUSJCZA5CNFSM6AAAAABNO4QQA2WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUHVDBM2.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5141/review/2275984077</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5141#pullrequestreview-2275984077",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5141#pullrequestreview-2275984077",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>