<p dir="auto">Things broken by Turbo pagination part 2, the previous part is <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2483003010" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5111" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5111/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5111">#5111</a>.</p>
<p dir="auto">Previous/next page visits are promoted to full page visits with Turbo rewriting most of <code class="notranslate"><head></code> tags. If new tags aren't sent together with the updated frame, old ones will be simply deleted. That includes deleting a page title and csrf token tags, which is going to break some functionality, particularly logouts.</p>
<p dir="auto">Open any page with Turbo pagination, click <em>Older/Newer</em> link, notice that the page title is gone. Then click <em>Logout</em> and it's not going to work. <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2223589340" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4646" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4646/hovercard?comment_id=2284931759&comment_type=issue_comment" href="https://github.com/openstreetmap/openstreetmap-website/pull/4646#issuecomment-2284931759">#4646 (comment)</a> worked correctly for changeset elements pagination because it's not promoted to page visits.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5175'>https://github.com/openstreetmap/openstreetmap-website/pull/5175</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5175/commits/20ab67e603ef795bb0fc77f420df79a22d6b6204" class="commit-link">20ab67e</a> Send <head> along with pagination frames</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5175/files">7 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5175/files#diff-3c862c4b76c5629c1aeb9076a68805579f475b14d126b8a9691ff9ae2e00f76e">app/controllers/diary_comments_controller.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5175/files#diff-4b73866ef57c70fca07c0f330d7a57aae939b11e4aae0514f303df3aa3762f89">app/controllers/diary_entries_controller.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5175/files#diff-cc7acbfb990b45e6f8cb1fe65cbd081a7819b596b03e0ac2ef2e82a9537d3278">app/controllers/issues_controller.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5175/files#diff-2602c06a2618f83c1470c924563b55c738e3c94ffb6480e637ca0f4ce130eaba">app/controllers/traces_controller.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5175/files#diff-cfdccd0a9d5df5a43aaad2a35d36ebbe187c52ad5fdc9846fa189d04537adb6e">app/controllers/users_controller.rb</a>
(2)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5175/files#diff-ebed7d674f23b4577accff97dcc399eab2216b026a6cf1c7629b48162e056dd7">app/views/layouts/turbo_frame_visit.html.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5175/files#diff-74ac87b606b7341e190b3117505821b596638e8a5aadf4350b780472b2e54285">test/system/user_logout_test.rb</a>
(23)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5175.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5175.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5175.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5175.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5175">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJQPWFCHB5JUHFL5UDZVU5QZAVCNFSM6AAAAABN3Z4E7KVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYTGMBSGU2DANQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPEOWMXKF4HE3VHRZTZVU5QZA5CNFSM6AAAAABN3Z4E7KWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHJLSNZPY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5175</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5175",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5175",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>