<p dir="auto">We don't need to notify anyone until the transaction is completed. The notification code was inside the transaction since the very beginning in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/b3d62bb85a03a0b68068d3d2e7801ec2cd2e3e7b/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/b3d62bb85a03a0b68068d3d2e7801ec2cd2e3e7b"><tt>b3d62bb</tt></a> and I don't know why.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5177'>https://github.com/openstreetmap/openstreetmap-website/pull/5177</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5177/commits/311afb76243b468160ffef80ff5880ad79a1c85a" class="commit-link">311afb7</a>  Rename comment text from comment to text</li>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5177/commits/24bb64cdd63b5ca33a920624896eef7a08cd3c34" class="commit-link">24bb64c</a>  Move notification code out of note update transactions</li>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5177/commits/d0546f6fff111d1676187d58cfcd8b294c758668" class="commit-link">d0546f6</a>  Move failed responses from test_*_success to test_*_fail</li>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5177/commits/ce7593ae6c74d95130763452897c01b97e422cf5" class="commit-link">ce7593a</a>  Test email notifications when notes are closed and reopened</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5177/files">2 files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5177/files#diff-6e9fe051c0ef757618e376ffe731dfca8d4960ef0838b7d6a05609b46ba0fad1">app/controllers/api/notes_controller.rb</a>
    (50)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5177/files#diff-b4cc80ae5a4279eef2a7494cb8c489220ce03acaf36932b2042247df9d316908">test/controllers/api/notes_controller_test.rb</a>
    (139)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5177.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5177.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5177.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5177.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5177">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJBLVPD3R3BW2C6WX3ZVWGVFAVCNFSM6AAAAABN4NHB7KVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYTGOBQGQYDENQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPW3DPEK4ZK6465P6TZVWGVFA5CNFSM6AAAAABN4NHB7KWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHJLVM27I.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5177</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5177",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5177",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>