<p dir="auto">This PR addresses "Language switcher on the homepage" issue mentioned in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="123230266" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/1115" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/1115/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/1115">#1115</a></p>
<p dir="auto">This PR is mainly based on <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2466082155" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5077" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5077/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5077">#5077</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1315878630" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/3618" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/3618/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/3618">#3618</a> and <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2068551504" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4461" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4461/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4461">#4461</a>. As solution using Wikimedia selector added external files, many lines of CSS and JS code, this version takes inspiration from <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2068551504" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4461" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4461/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4461">#4461</a> and creates a reusable language selector using <code class="notranslate"><select></code> tag.</p>
<p dir="auto">Language selector button, to be consistent, is not hidden when the user is logged in. Instead, it redirects to the "My Preferences" page, where user can change language preferences. When the user is logged out, clicking language selector opens language selection menu.</p>
<p dir="auto">The reason for logged in user redirection instead of any complex functionality of preferred language change while clicking language selector, was compatibility with the PR <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2068551504" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4461" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4461/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4461">#4461</a>. After both PRs will be merged, there will be one smooth simple UX flow for logged in users. Plus, it makes finding language selection page much easier for new users.</p>
<p dir="auto">Default view of the language selector:</p>
<p dir="auto"><a href="https://github.com/user-attachments/assets/49101573-eb7c-4ade-83e1-6720cd1111f9">357859639-0ca3007a-ff80-480b-8b37-1816193dc377.png (view on web)</a></p>
<p dir="auto">Opened language selector:</p>
<p dir="auto"><a href="https://github.com/user-attachments/assets/0012b643-7b69-47aa-aec2-62bda34179a6">image.png (view on web)</a></p>
<p dir="auto">Mobile view of the selector:</p>
<p dir="auto"><a href="https://github.com/user-attachments/assets/cc30cb9f-5197-48e3-ad50-b5ccd04b2b6a">Screenshot_20240912-144716.png (view on web)</a></p>
<p dir="auto">This PR has many different visual impacts, so to make description shorter instead of directly adding images, I'll add links to them.</p>
<p dir="auto">LTR screenshots:</p>
<p dir="auto"><a href="https://github.com/user-attachments/assets/772b883a-7911-4f34-a81f-90a0c46a5f68">Medium resolution menu</a><br>
<a href="https://github.com/user-attachments/assets/cede63b4-447c-430e-b23a-28904dbdc3a2">Medium resolution menu hover</a><br>
<a href="https://github.com/user-attachments/assets/18daace0-c617-4483-b7b0-9137906603bd">Small resolution menu</a></p>
<p dir="auto">RTL screenshots:</p>
<p dir="auto"><a href="https://github.com/user-attachments/assets/6cc3b52d-09a6-4795-ab6c-6c56d2f361c2">Default view</a><br>
<a href="https://github.com/user-attachments/assets/cb5306c5-96fa-418e-836e-71ef965f7fc5">Medium resolution menu</a><br>
<a href="https://github.com/user-attachments/assets/7a0e913f-e59d-47a2-85c3-8db9e0e1c3e3">Small resolution menu</a></p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5201'>https://github.com/openstreetmap/openstreetmap-website/pull/5201</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201/commits/64c4f7e97c2dcf835e6ed9c1fc1242310def14d9" class="commit-link">64c4f7e</a> Add locale selector</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201/files">9 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201/files#diff-e879318e8614f07f58768600b86c46fc8ae487263102154f14417daa52019dff">app/assets/images/sprite.svg</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201/files#diff-0e145ba000e96b1a45d230275e350e4e8514efb4db7dbcfa228fe1003896c9b4">app/assets/javascripts/application.js</a>
(1)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201/files#diff-f3d75a429346b0f71a92922e7bdc526c74f6211947050df3d331c05d3019e5b8">app/assets/javascripts/language_selector.js</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201/files#diff-e86a39e6d0b163f152db8843fc7d647a3f5d648de4a74f1732bef4474b6e5bc8">app/assets/stylesheets/common.scss</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201/files#diff-766c34fd6533171eaf54300c153f89d6002c35c02cfc9c5b219251f85180ad07">app/controllers/application_controller.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201/files#diff-cfdccd0a9d5df5a43aaad2a35d36ebbe187c52ad5fdc9846fa189d04537adb6e">app/controllers/users_controller.rb</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201/files#diff-6d2ef58207c92d1533287af551a075122ba98240a861819047a2ae77b7674f0b">app/views/layouts/_header.html.erb</a>
(18)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201/files#diff-e8ed8ce386aaf278c52395822b83452d2f56e8e50977a44282a1ebb345342066">app/views/shared/_language_selector.html.erb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201/files#diff-43c6cbf1d8474dfd3889f066ee578a693a1b3ca863f407b07663e0f59102b4ed">test/system/site_test.rb</a>
(12)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5201.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5201.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5201.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5201.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKUXJRGHOWIS6ABMGLZWFZY5AVCNFSM6AAAAABODAIFFCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUZDEMJQGQ4DKMA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLO3QIPLTF5BJSCRG7TZWFZY5A5CNFSM6AAAAABODAIFFCWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHJMVCECI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5201</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5201",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5201",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>