<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201#discussion_r1759222076">app/assets/javascripts/language_selector.js</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,6 @@
+$(document).ready(function () {
+  $(".language-change-trigger").on("change", function () {
</pre>
<p dir="auto">In the interests of ensuring turbo compatibility it's better to write this as:</p>
<pre class="notranslate"><code class="notranslate">$(document).on("change", ".language-change-trigger", function () {
</code></pre>
<p dir="auto">it probably doesn't natter in this case as it's in the header but there's no reason not to be safe in case it ever gets moved.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201#pullrequestreview-2303667225">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNFJQERVC3RZBE327DZWMMWRAVCNFSM6AAAAABODAIFFCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMBTGY3DOMRSGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLI52H5GFP2ZS3N5YW3ZWMMWRA5CNFSM6AAAAABODAIFFCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUJJ4WBS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5201/review/2303667225</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5201#pullrequestreview-2303667225",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5201#pullrequestreview-2303667225",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>