<p></p>
<p><b>@nenad-vujicic</b> approved this pull request.</p>

<p dir="auto">This works great on my side, thanks!</p>
<p dir="auto">Regarding detecting file types, it's very hard to do it quickly and efficiently (e.g. xmllint can check if it is valid XML file, but we will pay with higher execution time). /usr/bin/file returns XML file type only if it starts with "<?xml", which may narrow down the space of supported trace files (devices generating them).</p>
<p dir="auto">Regarding "Entity: line 1: parser error : Start tag expected, '<' not found" message, it's introduced by adding test_parse_error_notification which tries to load JPG file with XML reader. Perhaps the best would be to redirect stderr to temporary file which could be printed if this test fails?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5226#pullrequestreview-2318200364">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIC5QM6AWKCT6O6CODZXQLJVAVCNFSM6AAAAABOQHKFPKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMJYGIYDAMZWGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIQ6NOYVKU7DTE5LF3ZXQLJVA5CNFSM6AAAAABOQHKFPKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUKFTXCY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5226/review/2318200364</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5226#pullrequestreview-2318200364",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5226#pullrequestreview-2318200364",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>