<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201#discussion_r1771686010">app/views/layouts/_header.html.erb</a>:</p>
<pre style='color:#555'>> @@ -76,6 +85,15 @@
<li><%= link_to t("layouts.copyright"), copyright_path, :class => "dropdown-item" %></li>
<li><%= link_to t("layouts.help"), help_path, :class => "dropdown-item" %></li>
<li><%= link_to t("layouts.about"), about_path, :class => "dropdown-item" %></li>
+ <li>
+ <% if current_user && current_user.id %>
+ <%= link_to(preferences_path) do %>
+ <%= render "shared/language_selector", :hoverable => true, :black => true, :classes => "dropdown-item", :disabled => true %>
</pre>
<p dir="auto"><code class="notranslate">dropdown-item</code> here doesn't entirely work, and possibly other Bootstrap classes either don't work as expected or are missing. Some related odd behavior of language link/label:</p>
<ul dir="auto">
<li>not logged in, no compact mode: no focus outline</li>
<li>not logged in, compact mode: same + keyboard up/down controls stop working correctly</li>
<li>logged in, no compact mode: focus outline is present but non-standard because no <code class="notranslate">nav-link</code>, but if you add it you'll need more css fixes</li>
<li>logged in, compact mode: keyboard controls also not working correctly, in a slightly different manner</li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201#pullrequestreview-2322665130">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPSYG6SGITO63SCZ3LZYAYLXAVCNFSM6AAAAABODAIFFCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMRSGY3DKMJTGA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKPSKJEQHR2LGOMC3DZYAYLXA5CNFSM6AAAAABODAIFFCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUKOEHKU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5201/review/2322665130</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5201#pullrequestreview-2322665130",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5201#pullrequestreview-2322665130",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>