<p></p>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/gravitystorm/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/gravitystorm">@gravitystorm</a> I've reworked the PR a bit based on your feedback.</p>
<p dir="auto">Regarding the readability of the history perspective on the PR changes.</p>
<p dir="auto">Rebasing the branch destroys the git history which breaks the conversation messages attached to specific commits, but I recall that you prefer a rebase because you'd like to avoid merge commits since PRs are not squash-merged into the <code class="notranslate">master</code>-branch.</p>
<p dir="auto">At this point I'm happy to use this PR as a draft/proposal and rather have merge conflicts in this Proposal PR than breaking the Github Conversation UI.</p>
<p dir="auto">If this PR reaches a state in which maintainers are happy to introduce the changes into the <code class="notranslate">master</code>-branch I will create one or more clean slate PRs.</p>
<p dir="auto">Would that work for you?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4481#issuecomment-2368032533">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMQMAM7WQNJIPSAVXTZYAANFAVCNFSM6AAAAABB4FLGOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRYGAZTENJTGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLP4GACBHFLYIQUGC53ZYAANFA5CNFSM6AAAAABB4FLGOWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUNEVHRK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4481/c2368032533</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4481#issuecomment-2368032533",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4481#issuecomment-2368032533",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>