<p></p>
<p><b>@kcne</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5261#discussion_r1803315983">test/system/dashboard_test.rb</a>:</p>
<pre style='color:#555'>>
- friends_heading = find :element, "h2", :text => "My friends"
+ friends_heading = find :element, "h2", :text => "Followed users"
</pre>
<p dir="auto">Maybe use "Following" instead of "Followed users" for better clarity. It aligns with the common terminology users are familiar with, like "Following" and "Followers," which may feel more intuitive.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5261#discussion_r1803327351">config/locales/en.yml</a>:</p>
<pre style='color:#555'>> - heading: "Unfriend %{user}?"
- button: "Unfriend"
- success: "%{name} was removed from your friends."
- not_a_friend: "%{name} is not one of your friends."
+ follow_user:
+ heading: "Do you want to follow %{user}?"
+ button: "Follow User"
+ success: "You are now following %{name}!"
+ failed: "Sorry, failed to follow %{name}."
+ already_followed: "You already follow %{name}."
+ limit_exceeded: "You have followed a lot of users recently. Please wait a while before trying to follow any more."
+ unfollow_user:
+ heading: "Do you want to unfollow %{user}?"
+ button: "Unfollow"
+ success: "%{name} was unfollowed by you."
+ not_followed: "%{name} is not followed by you."
</pre>
<p dir="auto">A bit more active voicing alternative would be "You are not following %{name}".</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5261#discussion_r1803331099">config/locales/en.yml</a>:</p>
<pre style='color:#555'>> - remove_friend:
- heading: "Unfriend %{user}?"
- button: "Unfriend"
- success: "%{name} was removed from your friends."
- not_a_friend: "%{name} is not one of your friends."
+ follow_user:
+ heading: "Do you want to follow %{user}?"
+ button: "Follow User"
+ success: "You are now following %{name}!"
+ failed: "Sorry, failed to follow %{name}."
+ already_followed: "You already follow %{name}."
+ limit_exceeded: "You have followed a lot of users recently. Please wait a while before trying to follow any more."
+ unfollow_user:
+ heading: "Do you want to unfollow %{user}?"
+ button: "Unfollow"
+ success: "%{name} was unfollowed by you."
</pre>
<p dir="auto">This sound a bit passive to me, altough I'm not sure. Alternative could be something like "You successfully unfollowed %{name}."</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5261#discussion_r1803335867">config/locales/en.yml</a>:</p>
<pre style='color:#555'>> - heading: "Add %{user} as a friend?"
- button: "Add as friend"
- success: "%{name} is now your friend!"
- failed: "Sorry, failed to add %{name} as a friend."
- already_a_friend: "You are already friends with %{name}."
- limit_exceeded: "You have friended a lot of users recently. Please wait a while before trying to friend any more."
- remove_friend:
- heading: "Unfriend %{user}?"
- button: "Unfriend"
- success: "%{name} was removed from your friends."
- not_a_friend: "%{name} is not one of your friends."
+ follow_user:
+ heading: "Do you want to follow %{user}?"
+ button: "Follow User"
+ success: "You are now following %{name}!"
+ failed: "Sorry, failed to follow %{name}."
</pre>
<p dir="auto">Suggesting one more alternative: "Sorry, your request for following %{name} has failed." Wording sounds a bit unnatural here imho</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5261#pullrequestreview-2372819677">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPNAHDJFNESTADNQCLZ32ASXAVCNFSM6AAAAABP6QXVRWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZSHAYTSNRXG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPDJAEMGTHAG3DWBIDZ32ASXA5CNFSM6AAAAABP6QXVRWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUNNZNN2.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5261/review/2372819677</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5261#pullrequestreview-2372819677",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5261#pullrequestreview-2372819677",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>