<p></p>
<p><b>@gravitystorm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5261#discussion_r1803308006">config/routes.rb</a>:</p>
<pre style='color:#555'>> @@ -280,8 +280,8 @@
   resource :profile, :only => [:edit, :update]
 
   # friendships
-  match "/user/:display_name/make_friend" => "friendships#make_friend", :via => [:get, :post], :as => "make_friend"
-  match "/user/:display_name/remove_friend" => "friendships#remove_friend", :via => [:get, :post], :as => "remove_friend"
+  match "/user/:display_name/follow_user" => "friendships#follow_user", :via => [:get, :post], :as => "follow_user"
+  match "/user/:display_name/unfollow_user" => "friendships#unfollow_user", :via => [:get, :post], :as => "unfollow_user"
</pre>
<p dir="auto">From a quick look at some gems that implement this functionality (<a href="https://github.com/cmer/socialization">1</a>, <a href="https://github.com/tcocca/acts_as_follower">2</a>) the convention is to use "follow" as a noun, so table is <code class="notranslate">follows</code>, controller is <code class="notranslate">follows_controller</code>, model is <code class="notranslate">Follow</code> etc. But I think we should rename the controllers/models separately.</p>
<p dir="auto">What it does suggest though is that we should use resourceful routing with this in mind, so for example "/user/:display_name/follow" with create/destroy actions (and new/edit for the GET pages). See <code class="notranslate">user_mutes</code> for an example in the routes.rb file that's a bit like this.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5261#discussion_r1803308006">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNXQKK2BJ4OHEBQAD3Z3Z6OVAVCNFSM6AAAAABP6QXVRWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZSHAYDMNZTGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMWF3ISR55YMNJFERLZ3Z6OVA5CNFSM6AAAAABP6QXVRWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUNNYUEW.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5261/review/2372806731</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5261#discussion_r1803308006",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5261#discussion_r1803308006",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>