<p dir="auto">Instead of <em>submitted</em> and <em>commented</em> note colors switch to <em>created</em>, <em>resolved</em> and <em>commented</em>.</p>
<p dir="auto">Reasons:</p>
<ul dir="auto">
<li>Close actions were colored as <em>commented</em> even if notes were closed without any comments. Now they are going to be colored as <em>resolved</em>.</li>
<li><em>Submitted</em> is not a term we use for notes, we have "add a note" and notes "created by".</li>
<li>There was a <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4700#issuecomment-2221682594" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4700/hovercard">complaint</a> about the primary color used for submitted notes that is blue making links harder to see. What other color can we use? For example, the <em>success</em> color, like we do for unread messages. But that's the color of the resolved note marker, and then we might as well add the unresolved color.</li>
</ul>
<p dir="auto">Caveats:</p>
<ul dir="auto">
<li>I keep "submitted" in locale keys to avoid errors while <code class="notranslate">subheading_html</code> is not updated.</li>
<li>I ignore <em>reopen</em> events because if I don't, I'd have to treat them as <em>open</em> events but then there wouldn't be an equivalent to the previous <em>submitted</em> state. And the equivalent is green <em>created</em> + yellow <em>created and resolved</em>.</li>
<li>I had to add this <em>created and resolved</em> state because what if the user did both actions? I can't pick one more important color. If I look at note status changes, the latest action is the most important one and I'd have to color notes as <em>resolved</em>. But then again I'd lose the equivalent to the previous <em>submitted</em> state.</li>
</ul>
<p dir="auto"><a href="https://github.com/user-attachments/assets/03ac5999-0822-4c03-938d-a8447f3114a4">image.png (view on web)</a></p>
<p dir="auto">Dark mode:<br>
<a href="https://github.com/user-attachments/assets/8c88a294-bb1a-42d5-b169-051f68f34916">image.png (view on web)</a></p>
<p dir="auto">Legend while locale strings aren't updated:<br>
<a href="https://github.com/user-attachments/assets/754fcbe2-f27d-4103-9359-71932981a56a">image.png (view on web)</a></p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5269'>https://github.com/openstreetmap/openstreetmap-website/pull/5269</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5269/commits/4f4212abd012e1c89b5a5c20ebe5459d7dd80101" class="commit-link">4f4212a</a> Replace submitted note table color with created/resolved</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5269/files">3 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5269/files#diff-e86a39e6d0b163f152db8843fc7d647a3f5d648de4a74f1732bef4474b6e5bc8">app/assets/stylesheets/common.scss</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5269/files#diff-4fe647349351c7492508c788230b91b7f4445d4b821f6781ac7fcfad5e879f21">app/views/notes/index.html.erb</a>
(22)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5269/files#diff-44438ce218f5287c58d0017f965d888715635d94280669896f75841fbd7b4cd7">config/locales/en.yml</a>
(6)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5269.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5269.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5269.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5269.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5269">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKCSBEFBRGKR3WTDWDZ36TNLAVCNFSM6AAAAABQDTUCRCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU4TINJWHA3TCOI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKORMSGY44R77RIWO3Z36TNLA5CNFSM6AAAAABQDTUCRCWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHJVJP2B4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5269</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5269",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5269",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>