<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201#discussion_r1804852184">app/views/shared/_language_selector.html.erb</a>:</p>
<pre style='color:#555'>> +      <% Locale.available
+               .map { |locale| Language.find_by(:code => locale.to_s) }
+               .select { |locale| locale }
+               .sort_by { |locale| locale[:english_name] }
+               .each do |language| %>
+        <option class="form-select" value="<%= language.code %>" <%= "selected" if I18n.locale.to_s == language.code %>><%= language.name %></option>
</pre>
<p dir="auto">Using Language table is probably a bad idea. I tried this:</p>
⬇️ Suggested change
<pre style="color: #555">-      <% Locale.available
-               .map { |locale| Language.find_by(:code => locale.to_s) }
-               .select { |locale| locale }
-               .sort_by { |locale| locale[:english_name] }
-               .each do |language| %>
-        <option class="form-select" value="<%= language.code %>" <%= "selected" if I18n.locale.to_s == language.code %>><%= language.name %></option>
+      <% Locale.available
+               .select { |locale| I18n.exists? "shared.language_selector.language", :locale => locale, :fallback => false }
+               .sort_by { |locale| locale.to_s == "en" ? "English" : t(".language", :locale => locale) }
+               .each do |locale| %>
+        <option class="form-select" value="<%= locale.to_s %>" <%= "selected" if I18n.locale.to_s == locale.to_s %>><%= locale.to_s == "en" ? "English" : t(".language", :locale => locale) %></option>
</pre>

<p dir="auto">with this in locale file:</p>
<pre class="notranslate"><code class="notranslate">  share:
    language_selector:
      language: THIS LANGUAGE NAME
</code></pre>
<p dir="auto">Now translators have to add whatever is the appropriate representation of their language there, and then it will appear in the selector.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201#pullrequestreview-2375354012">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMASCUU5ZYFRAGUQTTZ367XDAVCNFSM6AAAAABODAIFFCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZVGM2TIMBRGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMNBYARFFQ4YI2XDRLZ367XDA5CNFSM6AAAAABODAIFFCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUNSUDJY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5201/review/2375354012</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5201#pullrequestreview-2375354012",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5201#pullrequestreview-2375354012",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>