<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201#discussion_r1812724030">app/views/shared/_language_selector.html.erb</a>:</p>
<pre style='color:#555'>> +      <% Locale.available
+               .map { |locale| Language.find_by(:code => locale.to_s) }
+               .select { |locale| locale }
+               .sort_by { |locale| locale[:english_name] }
+               .each do |language| %>
+        <option class="form-select" value="<%= language.code %>" <%= "selected" if I18n.locale.to_s == language.code %>><%= language.name %></option>
</pre>
<blockquote>
<p dir="auto">Translating language names using i18n and not having one source for them</p>
</blockquote>
<p dir="auto">i18n is going to be their <em>one source</em></p>
<blockquote>
<p dir="auto">may cause duplicate translations or inconsistency (because of multiple functionalities using language names).</p>
</blockquote>
<p dir="auto">We already have two different functionalities using two different sets of languages: i18n and languages of diary entries.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5201#discussion_r1812724030">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLI4UUB5RF27RZWNIZ3Z46NNZAVCNFSM6AAAAABODAIFFCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOBYGYZDKNBXGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOSKZICUIRBBL4PKE3Z46NNZA5CNFSM6AAAAABODAIFFCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUOL6EEG.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5201/review/2388625475</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5201#discussion_r1812724030",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5201#discussion_r1812724030",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>