<p></p>
<p><b>@gravitystorm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5293#discussion_r1819243689">app/controllers/user_roles_controller.rb</a>:</p>
<pre style='color:#555'>> +  def update
     @user.roles.create(:role => @role, :granter => current_user)
</pre>
<p dir="auto">I would suggest that <code class="notranslate">create</code> is a better method name, because:</p>
<ul dir="auto">
<li><code class="notranslate">create</code> and <code class="notranslate">destroy</code> are more natural opposites of each other than <code class="notranslate">update</code> and <code class="notranslate">destroy</code></li>
<li>Since the next line is also <code class="notranslate">@user.roles.create(...)</code> then having both the controller-method-name and relation-method  being the same (<code class="notranslate">create</code>) will make it easier for developers to understand the code.</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5293#pullrequestreview-2399386368">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLK7PO2WO2GNOR7V36TZ5ZBBZAVCNFSM6AAAAABQWKZICWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOJZGM4DMMZWHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKOXX4G3ZEZ33NIKCLZ5ZBBZA5CNFSM6AAAAABQWKZICWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUPAO5QA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5293/review/2399386368</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5293#pullrequestreview-2399386368",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5293#pullrequestreview-2399386368",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>