<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>

<p dir="auto">In addition to the inline comment this could do with tests at the controller or system level rather than just testing the model method.</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5297#discussion_r1829863356">app/models/note.rb</a>:</p>
<pre style='color:#555'>> @@ -34,6 +34,16 @@ class Note < ApplicationRecord
 
   scope :visible, -> { where.not(:status => "hidden") }
   scope :invisible, -> { where(:status => "hidden") }
+  scope :with_status, lambda { |status|
+    case status
+    when "open"
+      where(:status => "open")
+    when "closed"
+      where(:status => "closed")
+    else
+      all
+    end
+  }
</pre>
<p dir="auto">Rather than trying to handle the all case specially here I think I would make this much simpler, like the <code class="notranslate">with_status</code> on the issue model, and then add an <code class="notranslate">unless params[:status] == "all"</code> guard in the controller so that the filter isn't applied when all statuses are requested.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5297#pullrequestreview-2416462718">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMY6WFX45ZAZXATGIDZ7EI3NAVCNFSM6AAAAABQ5AHD4WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMJWGQ3DENZRHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPYNOZJ3LU6KICZFZTZ7EI3NA5CNFSM6AAAAABQ5AHD4WWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUQBBFX4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5297/review/2416462718</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5297#pullrequestreview-2416462718",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5297#pullrequestreview-2416462718",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>