<p dir="auto">The "remember me" checkbox has not been working properly, or rather it has been treated as checked even when it isn't.</p>
<p dir="auto">The reason is the "Gotcha" details in the <a href="https://api.rubyonrails.org/classes/ActionView/Helpers/FormBuilder.html#method-i-check_box" rel="nofollow">check_box documentation</a> which means that the parameter has the value <code class="notranslate">"0"</code> when unticked.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5303'>https://github.com/openstreetmap/openstreetmap-website/pull/5303</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5303/commits/035e996ab9609c3828bb5c1b1552c42e27fcd662" class="commit-link">035e996</a> Make the "remember me" option work as intended</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5303/files">2 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5303/files#diff-cdec550eeeb8fc63be2b5687170f594651a8d0b7f0465c9d807baef392639b6e">app/controllers/sessions_controller.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5303/files#diff-0ebf4c65ae927de1d02650f4caa7f2810e14eb64201b7570cb30939f0ee38719">test/controllers/sessions_controller_test.rb</a>
(18)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5303.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5303.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5303.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5303.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5303">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKNPWV4OPGBDUQBJTLZ7EG6TAVCNFSM6AAAAABRHGJHICVHI2DSMVQWIX3LMV43ASLTON2WKOZSGYZTMMRRGIYDIMA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIW3DEHAVLULCWXWBDZ7EG6TA5CNFSM6AAAAABRHGJHICWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHJ2ILHJA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5303</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5303",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5303",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>