<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5312#discussion_r1838607753">test/controllers/user_blocks_controller_test.rb</a>:</p>
<pre style='color:#555'>> +      get user_block_path(block)
+      assert_response :success
+      block.reload
+      assert_not block.needs_view
+      assert_equal Time.now.utc - 1.hour, block.deactivates_at
+    end
+  end
+
+  ##
+  # test clearing needs_view by showing a timed block to the blocked user
+  def test_show_sets_deactivates_at_for_timed_block
+    user = create(:user)
+    session_for(user)
+
+    freeze_time do
+      block = create(:user_block, :needs_view, :created_at => Time.now.utc, :ends_at => Time.now.utc + 1.day, :user => user)
</pre>
<p dir="auto">I recently got rid of all the <code class="notranslate">.day</code> uses in this file because they cause confusion when running the tests just before a DST change when a day may not be 24 hours so this should probably be <code class="notranslate">24.hours</code> instead.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5312#discussion_r1838608032">test/controllers/user_blocks_controller_test.rb</a>:</p>
<pre style='color:#555'>> +
+      get user_block_path(block)
+      assert_response :success
+      block.reload
+      assert_not block.needs_view
+      assert_equal Time.now.utc + 23.hours, block.deactivates_at
+
+      travel 1.hour
+
+      get user_block_path(block)
+      assert_response :success
+      block.reload
+      assert_not block.needs_view
+      assert_equal Time.now.utc + 22.hours, block.deactivates_at
+
+      travel 1.day
</pre>
<p dir="auto">Same here...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5312#pullrequestreview-2430432973">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOMA3KL2UHNQZIFXOT2AJEZNAVCNFSM6AAAAABRSA7X6CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMZQGQZTEOJXGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLP37ZVNJJ3HLLV5WRD2AJEZNA5CNFSM6AAAAABRSA7X6CWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUQ3V3M2.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5312/review/2430432973</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5312#pullrequestreview-2430432973",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5312#pullrequestreview-2430432973",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>