<p></p>
<p><b>@nertc</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5121#discussion_r1841712743">app/models/concerns/truncatable.rb</a>:</p>
<pre style='color:#555'>> + def truncate_html(html, max_length, empty_tag_length = 500)
+ doc = Nokogiri::HTML::DocumentFragment.parse(html)
+ accumulated_length = 0
+ truncated_node = nil
+
+ doc.traverse do |node|
+ if accumulated_length >= max_length
+ node.remove unless truncated_node.ancestors.include?(node)
+ next
+ end
+
+ next unless node.children.empty?
+
+ content_length = node.text? ? node.text.length : empty_tag_length
+ if accumulated_length + content_length >= max_length
+ node.content = node.text.truncate(max_length - accumulated_length) if node.text?
</pre>
<p dir="auto">If we discard it as a whole, diary entry of someone who created only one huge paragraph, won't be shown at all.<br>
If we keep it fully, diary entry of someone who created only one huge paragraph, will overload diary entries list.<br>
That's why I think truncation is the best method in this case.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5121#discussion_r1841712743">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKQXQCGZWXRWGBORQD2ARIUJAVCNFSM6AAAAABNFQLUA6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMZVGI3TKMBTGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJ65IDSTZPJKRJ5SOL2ARIUJA5CNFSM6AAAAABNFQLUA6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTURE5MRU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5121/review/2435275034</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5121#discussion_r1841712743",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5121#discussion_r1841712743",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>