<p></p>
<p dir="auto">Let me start by saying that yes, I'm disappointed, but I don't mean to hate. I understand that you're all busy, and that this is volunteer work. I'm not expecting anything from you. Please read my comments more as feedback on how I feel and how things are looking like from my end, written in the hope that the experience might improve for others in the future.</p>
<blockquote>
<p dir="auto">That's not why it was merged, and I think if you read <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2661819843" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5328" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/5328/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/5328">#5328</a> you'll see that I'm not "assuming that it's going to fix everyone's problems". That's a pretty unfair characterisation.</p>
</blockquote>
<p dir="auto">AFAICT, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2661819843" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5328" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/5328/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/5328">#5328</a> is not talking about <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2662198357" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5330" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5330/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5330">#5330</a> at all. I don't understand how "let's keep dimming the tiles, but just a bit less" is treated as a valid solution to the backlash about the "dark mode" that rolled out yesterday.</p>
<p dir="auto">And how was that selected as the way to go in the first place? Because <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="473706005" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/2332" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/2332/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/2332">#2332</a> sure doesn't seem to favor it. Instead, there was PR <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2247180875" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4712" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4712/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4712">#4712</a> that brought us here in the first place, merged with no discussion whatsoever, and without pinging any of the existing issues. This feels like "yeah whatever, keep talking, we're gonna do this my way now". And that's massively off-putting.</p>
<blockquote>
<p dir="auto">It's been less than 22 hours since you opened it. I haven't reviewed this PR specifically, but you can see from the discussion in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2661819843" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5328" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/5328/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/5328">#5328</a> that there's lots to consider about the invert+rotate approach. It's not a PR which is a straightforward merge, and even if it was, 22 hours is asking a lot in terms of turnaround from a handful of volunteers.</p>
</blockquote>
<p dir="auto">If this were a feature request, or even a normal bugfix, sure, I understand your argument. But from my perspective, the deployment yesterday <em>broke the map</em> for basically every dark mode user, with basically no option to get back the previous behavior. The only way people could continue using the OSM.org map was either by disabling dark mode for their whole browser (because that's a global setting both in Firefox and Chrome), or use a different browser just for looking at OSM.</p>
<p dir="auto">That's something that, in my book, should either be hotfixed or rolled back ASAP. And it's also something that wouldn't have happened in the first place if the whole "no we need to weigh the options against each other and thoroughly test and discuss this" attitude would've been applied <em>before</em> rolling out the change, and it feels unfair to <em>now</em> insist on it when the broken release was already deployed.</p>
<blockquote>
<p dir="auto">I think "failed" is also unfair. There's more to dark mode than just effect on the maps, it took months of work and dozens of changes across that rest of the site too.</p>
</blockquote>
<p dir="auto">And I congratulate you on this. Because I know that it's not easy, and it looked really good. I even acknowledged it at the top of this PR ("The current implementation of dark mode is already pretty good").</p>
<p dir="auto">But you'll also have to admit that breaking the map for a lot of users is a huge deal. I don't see how the dimmed tiles would've been approved by anyone who cares about accessibility, or uses dark mode. Therefore I have to conclude that it's not been tested or reviewed by the actual stakeholders before going live, and it made things significantly worse for them. I consider that a failure.</p>
<p dir="auto">That's okay, because failures happen, and then we either fix things or roll the changes back, but instead you're twiddling on some percentages and assume that it's gonna fix the issue, and that's just disheartening.</p>
<blockquote>
<p dir="auto"><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2285362548" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4769" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/4769/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/4769">#4769</a> was opened in May, but unfortunately there was no substantial discussion.</p>
</blockquote>
<p dir="auto">The lack of discussion might be related to <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="473706005" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/2332" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/2332/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/2332">#2332</a>, the issue titled "Dark Mode", opened <em>before the pandemic</em>, the one where people had been suggesting things for years, not being made aware of it.</p>
<p dir="auto">That the issue has been closed today, with new ones being created for all the different aspects, might make it easier from a project management perspective to keep track on the different topics. But please understand that for the people who have been waiting for five years to see progress on the issue, and now being presented with a half-baked non-solution without their involvement, it probably feels like a joke.</p>
<blockquote>
<blockquote>
<p dir="auto">not bother trying to upstream any improvements, or contribute to the website going forward.</p>
</blockquote>
<p dir="auto">That's a shame, we do welcome everyone to get involved.</p>
</blockquote>
<p dir="auto">And I really appreciate you taking the time to address the points I've brought up. I hope that this reply is helpful to you, too.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5325#issuecomment-2479858361">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLL7XVFW357RY7O7IV32AZJ6ZAVCNFSM6AAAAABRZ3RSY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZZHA2TQMZWGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPJ24LTZ7W4Q6673OT2AZJ6ZA5CNFSM6AAAAABRZ3RSY6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUTZ6RLS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5325/c2479858361</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5325#issuecomment-2479858361",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5325#issuecomment-2479858361",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>