<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<p dir="auto">I wonder about the overall approach of doing this in a concern - would it be better to do it in <code class="notranslate">RichText::Base</code> perhaps?</p>
<p dir="auto">What I envisage is a new method there to do truncation and then altering the <code class="notranslate">to_html</code> methods in the derived classes to take an optional truncation length (defaulting to <code class="notranslate">nil</code>) and apply the truncation method to their result if it's set - then instead of a boolean parameter the views can pass in a truncation length.</p>
<p dir="auto">Just a thought, but it seems with the current implementation things get messy when trying to deal with the order things are being done and what is and isn't sanitised etc.</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5121#discussion_r1848870857">app/models/concerns/truncatable.rb</a>:</p>
<pre style='color:#555'>> +      if accumulated_length >= max_length
+        node.remove unless !last_child.nil? && last_child.ancestors.include?(node)
+        next
+      end
+
+      next unless node.children.empty?
+
+      accumulated_length += node.text? ? node.text.length : empty_tag_length
+      if accumulated_length < max_length
+        last_child = node
+      else
+        node.remove
+      end
+    end
+
+    RichText::SimpleFormat.new.sanitize(doc)
</pre>
<p dir="auto">Why are we running sanitize here? The HTML was already sanitised before this was called, at least in the current use of this concern?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5121#pullrequestreview-2446310041">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLN57AFVA7S53YROX4L2BOBYBAVCNFSM6AAAAABNFQLUA6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINBWGMYTAMBUGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNHYBA7242OP22XTRD2BOBYBA5CNFSM6AAAAABNFQLUA6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTURZ65JS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5121/review/2446310041</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5121#pullrequestreview-2446310041",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5121#pullrequestreview-2446310041",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>