<p></p>
<blockquote>
<p dir="auto">... A "fixup commit" is a commit that's added to a pull request that fixes problems with code introduced in the same pull request.</p>
<p dir="auto">From CONTRIBUTING.md (emphasis added)</p>
<blockquote>
<p dir="auto">Avoid including "fixup" commits ...</p>
</blockquote>
</blockquote>
<p dir="auto">Is catching "fixup" commits (a line added (removed) in one commit and then removed (added) in a subsequent commit within the same PR) using a <code class="notranslate">danger workflow</code> something that could help maintainers? It’s a bit tricky to define what constitutes a "fixup" because, if a commit represents a logical unit, a line could have meaning in one commit but not necessarily in another, thus justifying its removal.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5314#issuecomment-2490857226">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLO32OAPRPT5HUJ7A2D2BW7L3AVCNFSM6AAAAABRVEQ2BGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJQHA2TOMRSGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPX426SWCJNGYONZPL2BW7L3A5CNFSM6AAAAABRVEQ2BGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUUO53QU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5314/c2490857226</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5314#issuecomment-2490857226",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5314#issuecomment-2490857226",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>