<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5362#discussion_r1867442284">app/assets/stylesheets/common.scss</a>:</p>
<pre style='color:#555'>> @@ -516,6 +511,23 @@ body.small-nav {
   }
 }
 
+@mixin dark-map-color-scheme {
+  .leaflet-tile-container .leaflet-tile,
+  .mapkey-table-entry td:first-child > * {
+    filter: brightness(.8);
</pre>
<p dir="auto">Doesn't the mentioned step 5 include the need for the filters to be set individually to give the cartographers a choice?<br>
I don't see that as a necessity for this PR, but already setting the filter through a custom property defined on the layer could ease the transition to that being implemented and also act as default and fallback:</p>
<div class="highlight highlight-source-css" dir="auto"><pre class="notranslate"><span class="pl-ent">here</span> {
    <span class="pl-c1">filter</span><span class="pl-kos">:</span> <span class="pl-en">var</span>(<span class="pl-s1">--dark-map-filter</span>);
}
<span class="pl-ent">somewhere</span> <span class="pl-ent">else</span> {
    .<span class="pl-c1">leaflet-layer</span> {
        <span class="pl-c1">--dark-map-filter</span><span class="pl-kos">:</span> <span class="pl-en">brightness</span>(<span class="pl-c1">.8</span>);
    }
}</pre></div>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5362#pullrequestreview-2475209721">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLKZL2B3JZ3HFM444T2DWAWVAVCNFSM6AAAAABSZEF6LSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZVGIYDSNZSGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKREROSI7ZENB7OJIT2DWAWVA5CNFSM6AAAAABSZEF6LSWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUTRCZ7S.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5362/review/2475209721</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5362#pullrequestreview-2475209721",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5362#pullrequestreview-2475209721",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>