<p></p>
<p dir="auto">I thought about this again and versioned notes may be what we actually want. We already kind of have note versions, they only contain state changes (open -> closed -> open again). But with tags we might want to record tag changes too. Being able to change tags allows to use them for more than just recording what tool the note was created with. We may want to use them for some kind of categorization (like "needs survey"). We might want to add some categories to already existing notes. Also we might want to add them to our own newly created notes because the tools we were using to create these notes don't allow adding tags or it was inconvenient to add the tags at the moment.</p>
<blockquote>
<p dir="auto">tags associated with comments should not replace the original ones</p>
</blockquote>
<p dir="auto">We don't have <em>tags associated with comments</em> anywhere else on the site.</p>
<blockquote>
<p dir="auto">they need to be "per interaction" so not just for the original note creation but at least for every comment</p>
</blockquote>
<p dir="auto">And what's the goal of that? Is it that important to record a client if it was just a comment? We're not adding tags to changeset comments and not trying to record clients in some other way, should we start doing that?</p>
<blockquote>
<p dir="auto">and maybe for opening and closing too</p>
</blockquote>
<p dir="auto">This is different to commenting. If anyone actually modifies the note, we might want to record that by adding a tag such as <code class="notranslate">edited_by</code> or <code class="notranslate">closed_by</code> or maybe even by overwriting <code class="notranslate">created_by</code>. Although in the latter case maybe we shouldn't be using <code class="notranslate">created_by</code> for notes at all (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2672317056" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5344" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5344/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5344">#5344</a> currently does), and just use <code class="notranslate">edited_by</code>.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/5294#issuecomment-2538781672">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLND3YL5HQWJ6FH3YKT2FF7CXAVCNFSM6AAAAABQ2HD3MWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZYG44DCNRXGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJZT5TXZLU5UETCYF32FF7CXA5CNFSM6AAAAABQ2HD3MWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUXKK56Q.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/issues/5294/2538781672</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/5294#issuecomment-2538781672",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/5294#issuecomment-2538781672",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>