<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>
<p dir="auto">I don't think leaflet-osm should be getting involved in automatic transforms - it should have the ability to select a dark tile version where there is one and any automatic transformations should only be in the osm.org code.</p><hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5396#discussion_r1882836643">vendor/assets/leaflet/leaflet.osm.js</a>:</p>
<pre style='color:#555'>> options = L.Util.setOptions(this, options);
- L.TileLayer.prototype.initialize.call(this, options.url);
+ url = isDarkMap ? options.darkUrl : options.lightUrl;
</pre>
<p dir="auto">There is no <code class="notranslate">lightUrl</code> anywhere?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5396#pullrequestreview-2500710248">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLW5D7TQ5BCY3ZN2ZT2FHWLDAVCNFSM6AAAAABTQPSKUSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMBQG4YTAMRUHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLNCQM7UT5YTPQMU3L2FHWLDA5CNFSM6AAAAABTQPSKUSWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUVBXHWQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5396/review/2500710248</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5396#pullrequestreview-2500710248",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5396#pullrequestreview-2500710248",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>