<p></p>
<p dir="auto">What's the source(s) of all the javascript in <code class="notranslate">vendor/</code>? I would expect to see <code class="notranslate">Vendorfile</code> updated, or preferably if these are sourced from e.g. node modules, then they should be included in package.json and added using the assets pipeline. If any of these are source files, i.e. written just for this project, then they should be in app/.</p>
<p dir="auto">Also, how does the inclusion of popper interact with the popper already included? We end up with <code class="notranslate">//= require popper</code> twice in application.js.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5402#issuecomment-2549573898">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKB2XISSXBBJUBRM5T2GCDUZAVCNFSM6AAAAABTWNRZO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBZGU3TGOBZHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPMMWIXGGEUU62GKUL2GCDUZA5CNFSM6AAAAABTWNRZO6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUX65UQU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5402/c2549573898</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5402#issuecomment-2549573898",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5402#issuecomment-2549573898",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>