<p dir="auto">This implements the refactorings suggested in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2748141711" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5415" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/5415/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/5415">#5415</a> and also improves the testing of the generated HTML to ensure that all the buttons are generated and reference the correct URL and title.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5417'>https://github.com/openstreetmap/openstreetmap-website/pull/5417</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5417/commits/68cca043fa152c35a14c4cdc15c561409e9678b3" class="commit-link">68cca04</a>  Drop render prefix from social_share_buttons function</li>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5417/commits/c696918e404444e5ac0a29a1551b431b225c92f2" class="commit-link">c696918</a>  Drop unused ability to filter social sharing sites</li>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5417/commits/eaf184380f19a4ccc9e77d3a7babff895f585626" class="commit-link">eaf1843</a>  Drop unused options from social_share_buttons</li>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5417/commits/235c7215584b4c5ccf906769dd2870f471e6182f" class="commit-link">235c721</a>  Use safe_join to join social sharing buttons</li>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5417/commits/5aa42bdbceb94ee4cb715c95462c32404b396e39" class="commit-link">5aa42bd</a>  Improve testing of social sharing buttons</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5417/files">3 files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5417/files#diff-22f6dbff3e22400e636b6f70bcaef16d9b6038aad4ac96daa11350633272bfc6">app/helpers/social_share_button_helper.rb</a>
    (58)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5417/files#diff-f54930d1342191d1e34f17bfc8a2b7f09fa283f05a3332495092abe2cbae50be">app/views/diary_entries/show.html.erb</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5417/files#diff-5aab28ad7860eb0242ea2309b822517bcb26c1ddbbb9686945b14d1fb8791f74">test/helpers/social_share_button_helper_test.rb</a>
    (35)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5417.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5417.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5417.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5417.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5417">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLAIKMTVZLLWZU4EP32GGV77AVCNFSM6AAAAABT3GJYR6VHI2DSMVQWIX3LMV43ASLTON2WKOZSG42DQMZXHAYDQOA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJKP4YX2JQCLHDFY4D2GGV77A5CNFSM6AAAAABT3GJYR6WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHKHUHL5A.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5417</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5417",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5417",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>