<p></p>
<p dir="auto">First of all, thank you for taking the time to do this post-merge review <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/gravitystorm/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/gravitystorm">@gravitystorm</a> . I wish these points had been raised earlier so I could have reassessed and addressed them before merging.</p>
<p dir="auto">I completely agree with your observations. As mentioned earlier, I drew some inspiration from the rails library mentioned in the issue. The <code class="notranslate">filter_allowed_sites</code> method was intended to validate a given list of sites and render only the valid ones. If no list was provided, it would default to rendering all sites, assuming that social share buttons without any provider wouldn’t be practical. That said, I agree the implementation could have been cleaner and better aligned with our use case.</p>
<p dir="auto">I noticed that <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/tomhughes/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/tomhughes">@tomhughes</a>  has already opened <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2748378088" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5417" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5417/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5417">#5417</a>  to address this. I wish i was active at the time issue was raised to do it instead. Never the less,  I appreciate the feedback and will keep this in mind as we refactor and finalize social sharing functionality.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/5415#issuecomment-2552446197">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPHOPU6UE2OADJNY5L2GH65TAVCNFSM6AAAAABT27MAIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJSGQ2DMMJZG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPX2XA6GINMGBSCMUT2GH65TA5CNFSM6AAAAABT27MAIKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUYEM6PK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/issues/5415/2552446197</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/5415#issuecomment-2552446197",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/5415#issuecomment-2552446197",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>