<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5416#discussion_r1891385635">app/assets/javascripts/leaflet.share.js</a>:</p>
<pre style='color:#555'>> @@ -411,34 +416,20 @@ L.OSM.share = function (options) {
$("#mapnik_image_width").text(mapWidth);
$("#mapnik_image_height").text(mapHeight);
- const layerId = map.getMapBaseLayerId();
- const layerKeys = new Map([
- ["mapnik", "standard"],
- ["cyclemap", "cycle_map"],
- ["transportmap", "transport_map"]
- ]);
+ const canDownloadImage = layer && layer.options.canDownloadImage;
</pre>
<p dir="auto">This doesn't guarantee a boolean valued result - specifically if the <code class="notranslate">canDownloadImage</code> key is missing then the result is <code class="notranslate">undefined</code> not <code class="notranslate">false</code> and at least in Firefox calling <code class="notranslate">toggle(undefined)</code> toggles the current visibility instead of always hiding the element though I don't think the behaviour is defined at all by jQuery.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5416#pullrequestreview-2513743852">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLK3IEXVGJ7GUTSHFUT2GKC7FAVCNFSM6AAAAABT3EZ2ROVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMJTG42DGOBVGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOP75L4QJ36CHMAXMD2GKC7FA5CNFSM6AAAAABT3EZ2ROWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUV2SX6Y.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5416/review/2513743852</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5416#pullrequestreview-2513743852",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5416#pullrequestreview-2513743852",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>