<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<p dir="auto">This mostly looks fine. I think the only thing I'm not sure about is moving <code class="notranslate">user#details</code> into a separate controller - it's basically an alias for <code class="notranslate">user#show</code> so does it make any sense to separate it?</p>
<p dir="auto">That said <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/gravitystorm/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/gravitystorm">@gravitystorm</a> has a better grasp than me of what is the canonical rails to do these things so I'd be interest to here what he thinks.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5433#pullrequestreview-2519601627">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLO5FPARZSXEVQBDUYL2G2MJXAVCNFSM6AAAAABUAFLIKKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMJZGYYDCNRSG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPB2UVMLNY6JVBDGN32G2MJXA5CNFSM6AAAAABUAFLIKKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUWFYI5W.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5433/review/2519601627</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5433#pullrequestreview-2519601627",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5433#pullrequestreview-2519601627",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>