<p></p>
<p><b>@nertc</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5439#discussion_r1898348555">app/views/profiles/edit.html.erb</a>:</p>
<pre style='color:#555'>> @@ -40,6 +40,21 @@
     </div>
   </fieldset>
 
+  <fieldset class="mb-3">
+    <legend><%= t ".social_links.legend" %></legend>
+    <div id="social_links">
+      <%= f.fields_for :social_links do |social_link_form| %>
+        <div class="social-link-fields row mb-3">
+          <%= social_link_form.text_field :url, :hide_label => true, :wrapper_class => "col-sm-8" %>
+          <%= social_link_form.check_box :_destroy, :wrapper_class => "d-none social_link_destroy" %>
+          <%= social_link_form.label :_destroy, t(".social_links.remove"), :class => "btn btn-outline-primary col-sm-1 align-self-start" %>
+        </div>
+      <% end %>
+    </div>
+
+    <%= link_to "+", "#", :id => "add-social-link", :class => "btn btn-outline-primary" %>
</pre>
<p dir="auto">I had a different logic that needed a link, as I changed logic, I agree with you, I'll change it to button.</p>
<p dir="auto">My idea was that <code class="notranslate">+</code> sign doesn't require any additional icons and is intuitive, while <code class="notranslate">Remove</code> needs <code class="notranslate">trash icon</code> to be intuitive (<code class="notranslate">-</code> sign doesn't always mean removal and sometimes it may be ambiguous). But I agree with you, maybe it's better to be consistent in this too. Which one do you think is better, to change <code class="notranslate">+</code> sign to <code class="notranslate">Add</code> (which will be much easier and less-code solution) or to change <code class="notranslate">Remove</code> to <code class="notranslate">trash icon</code> (which may be nicer in terms of UI, but will require trash icon and, therefore, more code)?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5439#discussion_r1898348555">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPENWC3GTVCW6JKNVD2HUD2NAVCNFSM6AAAAABUCYTSJCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRTHAYDMNZUGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLI67XXPNQKO66L3RSL2HUD2NA5CNFSM6AAAAABUCYTSJCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUWNY6BU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5439/review/2523806746</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5439#discussion_r1898348555",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5439#discussion_r1898348555",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>