<p dir="auto">Includes <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2762072078" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5446" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5446/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5446">#5446</a></p>
<p dir="auto">There's an issue that the <em>resend confirmation email</em> link reads "click here" <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2753367891" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5431" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/5431/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/5431">#5431</a>. I think there shouldn't be any link at all, this should be a button because it does something, not just loads a page. And the page shouldn't be accessible by GET, the button should trigger POST. When you accept the confirmation link, there's also a button which posts, but its hidden and autoclicked by javascript. The current resend link+GET existed since <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/bddf524c888c7364119a673e9b6c0518b0c6f93d/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/bddf524c888c7364119a673e9b6c0518b0c6f93d"><tt>bddf524</tt></a>.</p>
<p dir="auto"><span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #5431.">Fixes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2753367891" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5431" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/5431/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/5431">#5431</a> by not having a link, and not writing "click here" on a button.</p>
<p dir="auto"><a href="https://github.com/user-attachments/assets/17ce59ea-fd7d-420c-bb35-91b09603074b">image.png (view on web)</a></p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5447'>https://github.com/openstreetmap/openstreetmap-website/pull/5447</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5447/commits/c883f02161ca4530e37eaafa7f0272b7f3f04c7a" class="commit-link">c883f02</a> Add within_content_body system test helper</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5447/commits/ef6edfff34888ae9c9564bfab84e5eade33e26c6" class="commit-link">ef6edff</a> Test signup with confirmation email</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5447/commits/127e376bf0a9c42e98af5f9b6251d7a93c5ead69" class="commit-link">127e376</a> Move code that runs after user save from save_new_user to create method</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5447/commits/cde73ae57792bc6089081e54549104ae45971b24" class="commit-link">cde73ae</a> Replace resent confirmation link with button</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5447/files">7 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5447/files#diff-cfdccd0a9d5df5a43aaad2a35d36ebbe187c52ad5fdc9846fa189d04537adb6e">app/controllers/users_controller.rb</a>
(40)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5447/files#diff-596485415afaa248c73d36eeb3a5be71b78f19acaedd02fd5dbf9bad11145d18">app/views/confirmations/confirm.html.erb</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5447/files#diff-44438ce218f5287c58d0017f965d888715635d94280669896f75841fbd7b4cd7">config/locales/en.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5447/files#diff-959bc9abc46a55332bb64d5155a79323afa75a50ec1a2137ddd22d926f62c6c5">config/routes.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5447/files#diff-58be79ee432aa1a1e12529b3141879d9c9503ac6e071c47e2d53462d339362b7">test/application_system_test_case.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5447/files#diff-0d2e03e45f001516dac5c734d8c0cdbff7a73028598ed5d2f9f8623e52c6099e">test/controllers/confirmations_controller_test.rb</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5447/files#diff-18d5b788986f58ce72b0d22695d761f641291806f2abd7e076552194de3bf74b">test/system/user_signup_test.rb</a>
(88)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5447.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5447.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5447.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5447.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5447">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKBIUWF3MP2ZLGLIEL2H5S2RAVCNFSM6AAAAABUKMEBOOVHI2DSMVQWIX3LMV43ASLTON2WKOZSG43DEMBYGU2TQOI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOR2SETIG4O6L3Q67L2H5S2RA5CNFSM6AAAAABUKMEBOOWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHKJIQU2U.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5447</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5447",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5447",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>