<p dir="auto">Currently <code class="notranslate">save_new_user</code> does other things like redirects after the actual save. That obscures which pages are reachable from actions that call <code class="notranslate">save_new_user</code>, see <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2753367891" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5431" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/5431/hovercard?comment_id=2564561794&comment_type=issue_comment" href="https://github.com/openstreetmap/openstreetmap-website/issues/5431#issuecomment-2564561794">#5431 (comment)</a>.</p>
<p dir="auto">Also <code class="notranslate">save_new_user</code> accesses referer in two different ways: as a function argument and as <code class="notranslate">params[:referer]</code>.</p>
<hr>
<p dir="auto">Added test for clicking <em>Sign Up</em>, filling out email-login-password, clicking <em>Sign Up</em>, opening confirmation link from email.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5446'>https://github.com/openstreetmap/openstreetmap-website/pull/5446</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5446/commits/c883f02161ca4530e37eaafa7f0272b7f3f04c7a" class="commit-link">c883f02</a>  Add within_content_body system test helper</li>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5446/commits/ef6edfff34888ae9c9564bfab84e5eade33e26c6" class="commit-link">ef6edff</a>  Test signup with confirmation email</li>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5446/commits/127e376bf0a9c42e98af5f9b6251d7a93c5ead69" class="commit-link">127e376</a>  Move code that runs after user save from save_new_user to create method</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5446/files">3 files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5446/files#diff-cfdccd0a9d5df5a43aaad2a35d36ebbe187c52ad5fdc9846fa189d04537adb6e">app/controllers/users_controller.rb</a>
    (40)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5446/files#diff-58be79ee432aa1a1e12529b3141879d9c9503ac6e071c47e2d53462d339362b7">test/application_system_test_case.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5446/files#diff-18d5b788986f58ce72b0d22695d761f641291806f2abd7e076552194de3bf74b">test/system/user_signup_test.rb</a>
    (53)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5446.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5446.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5446.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5446.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5446">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIPL7B4PCBF7RCV5A32H5KYVAVCNFSM6AAAAABUKKTAW2VHI2DSMVQWIX3LMV43ASLTON2WKOZSG43DEMBXGIYDOOA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLPBDBZ4G6DEEKZLLL2H5KYVA5CNFSM6AAAAABUKKTAW2WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHKJIPABY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5446</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5446",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5446",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>