<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5261#discussion_r1900742061">app/models/follow.rb</a>:</p>
<pre style='color:#555'>> +  belongs_to :befriender, :class_name => "User", :foreign_key => :user_id, :inverse_of => :follows
+  belongs_to :befriendee, :class_name => "User", :foreign_key => :friend_user_id, :inverse_of => :follows
</pre>
<p dir="auto">We probably want to keep the existing db column names like <code class="notranslate">friend_user</code> for now, but what about <code class="notranslate">:befriender</code> and <code class="notranslate">:befriendee</code>? Currently you have code like this, mixing "follow" and "friend" terminology:</p>
<div class="highlight highlight-source-ruby" dir="auto"><pre class="notranslate"><span class="pl-v">Follow</span><span class="pl-kos">.</span><span class="pl-en">find_by</span><span class="pl-kos">(</span><span class="pl-pds">:befriender</span> <span class="pl-c1">=></span> <span class="pl-en">user</span><span class="pl-kos">,</span> <span class="pl-pds">:befriendee</span> <span class="pl-c1">=></span> <span class="pl-en">follow</span><span class="pl-kos">)</span></pre></div>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5261#pullrequestreview-2527347738">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLL3LTZI32CI742PGY32IUJKVAVCNFSM6AAAAABP6QXVRWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRXGM2DONZTHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOXMTQ7BELYQARKYHD2IUJKVA5CNFSM6AAAAABP6QXVRWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUWURCBU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5261/review/2527347738</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5261#pullrequestreview-2527347738",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5261#pullrequestreview-2527347738",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>