<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5454#discussion_r1901163373">app/helpers/user_blocks_helper.rb</a>:</p>
<pre style='color:#555'>> @@ -27,14 +27,10 @@ def block_status(block)
 
   def block_short_status(block)
     if block.active?
-      if block.needs_view?
-        if block.ends_at > Time.now.utc
-          t("user_blocks.helper.short.active_unread")
-        else
-          t("user_blocks.helper.short.expired_unread")
-        end
-      else
+      if block.ends_at > Time.now.utc || block.deactivates_at
</pre>
<p dir="auto">Is the <code class="notranslate">deactivates_at</code> test needed?</p>
<p dir="auto">I don't see how that will ever be set for a block which is active but which has passed the <code class="notranslate">ends_at</code> test, given that a block is active if it hasn't passed the end time or needs a view, and viewing a block that needs a view clears the needs view flag.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5454#pullrequestreview-2528055153">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJEZX4I3DQPYOBF42L2IWCIPAVCNFSM6AAAAABUPMHCA2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRYGA2TKMJVGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNLOYOQ3W4CV34EQ5D2IWCIPA5CNFSM6AAAAABUPMHCA2WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUWV4HXC.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5454/review/2528055153</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5454#pullrequestreview-2528055153",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5454#pullrequestreview-2528055153",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>