<ul dir="auto">
<li>make user terms a nested resource inside the account resource</li>
<li><code class="notranslate">GET /user/terms</code> changed to <code class="notranslate">GET /account/terms</code>. It's inconvenient to have it at <code class="notranslate">/user/terms</code> because that depends on the declaration order. If user resources are declared first, they capture <code class="notranslate">terms</code> as a username. I still add a redirect from <code class="notranslate">/user/terms</code> to <code class="notranslate">/account/terms</code> which has to come before <code class="notranslate">resources :users</code>, but with redirects it's obvious that they are temporary.</li>
<li><code class="notranslate">POST /user/save</code> changed to <code class="notranslate">PUT /account/terms</code>. With <code class="notranslate">user#save</code> it's not clear that this is a target of the terms form.</li>
</ul>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/5462'>https://github.com/openstreetmap/openstreetmap-website/pull/5462</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/commits/0ffe3cea2805fdda9a038189aed1b4992fc64213" class="commit-link">0ffe3ce</a> Remove slashes from body css classes</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/commits/92d15db3c46040ed0477d5e328895d28eb150bc0" class="commit-link">92d15db</a> Use resourceful routes for terms view/accept/decline</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/files">16 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/files#diff-debf59904131dc89a88ab44cbb1d6deaaa5a7d70c0507f674080df62f7c8e41f">app/abilities/ability.rb</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/files#diff-e86a39e6d0b163f152db8843fc7d647a3f5d648de4a74f1732bef4474b6e5bc8">app/assets/stylesheets/common.scss</a>
(2)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/files#diff-51243a95c08f37346b52b223c3e9ca80e954787aa019156279ff2e52ab9fc2ae">app/controllers/accounts/terms_controller.rb</a>
(65)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/files#diff-766c34fd6533171eaf54300c153f89d6002c35c02cfc9c5b219251f85180ad07">app/controllers/application_controller.rb</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/files#diff-8ac25145a80d1093fb7a8f1098aa9d5b0a1d70ced7333342a9ec569227d0a82f">app/controllers/concerns/session_methods.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/files#diff-cfdccd0a9d5df5a43aaad2a35d36ebbe187c52ad5fdc9846fa189d04537adb6e">app/controllers/users_controller.rb</a>
(52)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/files#diff-5f3fc5e3977d242572aa1d08551f5eb557de0ccaff30370838ee9df5386ea0da">app/helpers/application_helper.rb</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/files#diff-e60a309ef4c891e6cb7845dfcb970684e61c569372bb66ea1ac9c3a16e699eac">app/views/accounts/edit.html.erb</a>
(2)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/files#diff-ffdffc577550a82b2af551e4730b75ee214ef3f3f047691a5a3f0ad0d6fb0adf">app/views/accounts/terms/_terms.html.erb</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/files#diff-407ac635f4f20e4e62a4162ff0c6478755de360c79ac91be4452bc136e9f9491">app/views/accounts/terms/_terms_declined_flash.html.erb</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/files#diff-7e0fe409d2d3256a2a8bd9a9b92db0ffa0564c3b47b4baf618efb182ff26a9fe">app/views/accounts/terms/show.html.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/files#diff-44438ce218f5287c58d0017f965d888715635d94280669896f75841fbd7b4cd7">config/locales/en.yml</a>
(57)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/files#diff-959bc9abc46a55332bb64d5155a79323afa75a50ec1a2137ddd22d926f62c6c5">config/routes.rb</a>
(8)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/files#diff-d03a223e4a11120c3e4b07067ae0776e06b350dd8daad071cdfd9b75b5434d46">test/controllers/accounts/terms_controller_test.rb</a>
(91)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/files#diff-2719d3c650da3c587f727ca3c105e6bc93a7113f85717bb15983543cf4f85ae5">test/controllers/users_controller_test.rb</a>
(75)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462/files#diff-5282e62ded5f4eeb7cedcc9637a0877d488ea1559fce342df79cf2c60e7dbe57">test/integration/user_terms_seen_test.rb</a>
(10)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5462.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/5462.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/5462.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/5462.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJSL5YEC5IAJ4VSMED2I7BWJAVCNFSM6AAAAABUTAYGOSVHI2DSMVQWIX3LMV43ASLTON2WKOZSG43DQNZZHE2DGNQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMGI5KZPAEP2SGARPD2I7BWJA5CNFSM6AAAAABUTAYGOSWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHKKCEGZQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5462</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5462",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5462",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>