<p></p>
<p><b>@HolgerJeromin</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5468#discussion_r1903220198">app/assets/javascripts/index/new_note.js</a>:</p>
<pre style='color:#555'>> @@ -162,6 +172,9 @@ OSM.NewNote = function (map) {
newNoteMarker.dragging.disable();
createNote(location, text, (feature) => {
+ if (typeof OSM.user === "undefined") {
+ localStorage.setItem("anonymousNotesCount", anonymousNotesCount + 1);
</pre>
<p dir="auto">If we keep <code class="notranslate">localstorage</code> (see <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/AntonKhorev/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/AntonKhorev">@AntonKhorev</a> comment):<br>
<code class="notranslate">localStorage.setItem</code> can throw an exception.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5468#pullrequestreview-2530845984">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLL3OF6TG2LATTDWHJ32JDTVXAVCNFSM6AAAAABUTQNBICVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMZQHA2DKOJYGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMJTA6LCD3S33ZEU3D2JDTVXA5CNFSM6AAAAABUTQNBICWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUW3GSSA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5468/review/2530845984</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5468#pullrequestreview-2530845984",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5468#pullrequestreview-2530845984",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>