<p></p>
<p><b>@gravitystorm</b> requested changes on this pull request.</p>

<p dir="auto">Looks good to me, one small change in the tests.</p>
<p dir="auto">I also appreciate the tests are slightly refactored, and this is an improvement.</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462#discussion_r1907596696">test/integration/user_terms_seen_test.rb</a>:</p>
<pre style='color:#555'>> @@ -25,12 +25,12 @@ def test_terms_presented_at_login
     assert_template "sessions/new"
     post "/login", :params => { :username => user.email, :password => "test", :referer => "/diary/new" }
     # but now we need to look at the terms
-    assert_redirected_to :controller => :users, :action => :terms, :referer => "/diary/new"
+    assert_redirected_to "/account/terms?#{{ :referer => '/diary/new' }.to_query}"
</pre>
<div class="highlight highlight-source-ruby" dir="auto"><pre class="notranslate"><span class="pl-en">assert_redirected_to</span> <span class="pl-en">account_terms_path</span><span class="pl-kos">(</span><span class="pl-pds">:referer</span> <span class="pl-c1">=></span> <span class="pl-s">"/diary/new"</span><span class="pl-kos">)</span></pre></div>
<p dir="auto">... is a bit easier to read</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5462#pullrequestreview-2537851315">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIQK72ICC5KBPLAZR32JVTM7AVCNFSM6AAAAABUTAYGOSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMZXHA2TCMZRGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKLOZCOMJL5Z3XNRUL2JVTM7A5CNFSM6AAAAABUTAYGOSWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUXISE3G.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5462/review/2537851315</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5462#pullrequestreview-2537851315",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5462#pullrequestreview-2537851315",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>