<p></p>
<p><b>@1ec5</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5493#discussion_r1912341526">config/locales/en.yml</a>:</p>
<pre style='color:#555'>> + arrondissement: "Arrondissement Boundary"
+ borough: "Borough Boundary"
+ cercle: "Cercle Boundary"
+ city: "City Boundary"
+ comarca: "Comarca Boundary"
+ county: "County Boundary"
+ departement: "Department Boundary"
+ department: "Department Boundary"
+ district: "District Boundary"
+ distrito: "District Boundary"
+ freguesia: "Freguesia Boundary"
+ local_authority: "Local Authority Boundary"
+ municipality: "Municipal Boundary"
+ municipi: "Municipal Boundary"
+ município: "Municipal Boundary"
+ nation: "International Boundary"
+ national: "International Boundary"
+ neighbourhood: "Neighborhood Boundary"
+ parish: "Parish Boundary"
+ province: "Provincial Boundary"
+ região: "Regional Boundary"
+ region: "Regional Boundary"
+ state: "State Boundary"
+ town: "Town Boundary"
+ township: "Township Boundary"
+ village: "Village Boundary"
</pre>
<p dir="auto">For starters, I added a translatable string for each of the 30 or so <code class="notranslate">border_type=*</code> values that occur most frequently with <code class="notranslate">boundary=administrative</code>. Only one translatable string is provided per <code class="notranslate">border_type=*</code> value globally. This will likely present a problem for some languages that would translate English words like “district”, “county”, or “town” differently depending on the country. I think we’ll need to add some more specific strings qualified by country code, as explained in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2763386568" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5450" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/5450/hovercard?comment_id=2566049746&comment_type=issue_comment" href="https://github.com/openstreetmap/openstreetmap-website/issues/5450#issuecomment-2566049746">#5450 (comment)</a>, but it’ll require a bit more research to find out which values are important in which countries.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5493#pullrequestreview-2545317289">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPPRSR47WRIPQGVYED2KG423AVCNFSM6AAAAABVAPFHJOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNBVGMYTOMRYHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIVOKVTE7PBHDYZPFT2KG423A5CNFSM6AAAAABVAPFHJOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUXWZ22S.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5493/review/2545317289</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5493#pullrequestreview-2545317289",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5493#pullrequestreview-2545317289",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>