<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<p dir="auto">I'm not totally convinced showing the numeric level is useful but generally this looks good apart from the specific point I've mentioned in a comment.</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5493#discussion_r1912486554">app/controllers/geocoder_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -101,9 +101,13 @@ def search_osm_nominatim
       if klass == "boundary" && type == "administrative"
         rank = (place.attributes["address_rank"].to_i + 1) / 2
         prefix_name = t "geocoder.search_osm_nominatim.admin_levels.level#{rank}", :default => prefix_name
+        border_type = false
+        place_type = false
</pre>
<p dir="auto">I think <code class="notranslate">nil</code> would be a better initial value here given they are going to be strings if any match is found.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5493#pullrequestreview-2545469269">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLDC24H3OGZADQ4RL32KKJUBAVCNFSM6AAAAABVAPFHJOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNBVGQ3DSMRWHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKCU5T3IOJK6LOWWSL2KKJUBA5CNFSM6AAAAABVAPFHJOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUXXDDVK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5493/review/2545469269</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5493#pullrequestreview-2545469269",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5493#pullrequestreview-2545469269",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>